Make AtomicCommitArgs const in the different helper functions to build
the AtomicRequest. Additionally, reorder the parameters to reflect the
convention that input parameters are listed first, and out parameters
are listed after.
Change-Id: I0277ec4129fbcd6312e6df9ae3f15600e9755520
Add AtomicRequest struct to wrap the pending DrmModeAtomicReq and
related kms objects and state for the pending atomic commit.
After the AtomicRequest's property set has been committed, update the
internal DrmAtomicStateManager state to reflect what has been committed.
Change-Id: I49d39649eb957d69f724b53b91577a347a75527e
Rather than initializing the state associated with a new frame by
copying committed_frame_state_, check committed_frame_state_ directly
when needed.
Change-Id: I62043e15e70669ce6a8ac4635101d13d8efd7f15
In some cases, the position of the cursor is controlled by the src rect.
For example, this is done when the cursor extends beyond the top or left
edges of the screen. This is not compatible with the hw cursor plane
however, because scaling and panning are both disallowed. As a workaround,
the position of the dst rect needs to be adjusted in the opposite
direction (in some cases taking a negative-valued position,) which
will correctly position the cursor while also assigning an acceptible
value to the src rect.
Change-Id: Ide7f75e01481bcd602a33d222d1ae6862703a1cd
drm_hwc currently does not support tone mapping. This causes a visual
color flickers when switching between CLIENT and DEVICE composition.
Temporarily disable non-native color modes until tone mapping work is
completed.
Change-Id: I114a12c474990a5a81181c52307469c7b139a2b0
Signed-off-by: Sasha McIntosh <sashamcintosh@google.com>
Add some const correctness to HwcDisplay. Narrow the public
interface of HwcDisplay to avoid exposing non-const members
unnecessarily.
Change-Id: I691c9e0025065085ca1e2045bb1d6614535fdbdc
Since CreateComposition is only being used in the present path, rename
it to CommitComposition to indicate that it's going to commit the
composition that was previously created during Validate.
Change-Id: Ia4627ff1e32b655273421510f8e1b844c6dd5e06
Making TestComposition const ensures that the Backend can't modify any
HwcDisplay state while creating and validating a composition.
Also make a bunch of other stuff const-correct since there is a const
version of GetPipe()
Change-Id: Ib7769d290148ce496b0165b64806dbd0a601b213
The client layer may be updated as part of Present, since the Client
doesn't know if the client layer is used or not until after Validate is
complete.
Move PopulateLayerData call out of CreateFrameUpdateCommit so that
CreateFrameUpdateCommit doesn't modify HwcDisplay state.
Change-Id: I0a78075f9476e0d27111b860b6a39fb46814b235
DrmKmsPlan lifetime is used to manage ownership of drm planes that have
affinity for multiple crtcs. As such, the DrmKmsPlan lifetime needs to
persist from a Validate call to when the composition is Presented to
ensure that such planes aren't stolen by another display.
Rather than stashing the DrmKmsPlan as part of TestComposition, return
the DrmKmsPlan as part of the Backend's Validate. HwcDisplay::Validate
then becomes responsible for lifetime management of the resulting
DrmKmsPlan as before.
Change-Id: I14ae115b2eed5c9b27e70f0b695fbbc4f3a4faa6
Extract the functionality to create the AtomicCommitArgs for a frame
update and call this from the TestComposition and CreateComposition
paths.
Change-Id: Ibb0695fd37e9f43eb8f97b3fd901109839d0f9ea
Rather than using next_config to determine if there was a config change
during the frame update, check the a_args.
Change-Id: Ib71dd3d542d7915e1fbfba0045c1d604382b1aab
QueueConfig allows for a seamless refresh rate change to be queued at
some arbitrary point in the future.
Previous behavior was to report `desired_time` as the time to request
a new frame from the client to apply the refresh rate change. Since
`desired_time` could be any arbitrary point in time, this may not align
with the current refresh rate.
This change addresses a failure in
SetActiveConfigWithConstraints_Delayed exposed by the previous change to
avoid setting the active_config_id until a full commit.
Change-Id: I92888cd1a6a330455f9e7e496d6900d494605248
HwcDisplay internal tracking state should only be modified for the
commit, not for the test commit
Change-Id: Idd63e300e724ff1b6986362d2b47e7b024346e05
This change cleans up some typing within Backend around data which
was inconsistently being handled as int, uint32_t, or size_t. This
change resolves an instance of integer underflow.
Change-Id: I4a2aa352b6cb4d1ff74929eb67c7edfc907cdb0c
In Android 16, some CtsGraphicsTestCases test names have changed which
causes the module to fail. Update the test names.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Android 16 added a new test, GetSupportedRefreshRatesIsDivisorRate,
which will fail when CI is updated to Android 16.
Add the ability to skip a CTS test and skip this test for now.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Update the commands for launching cuttlefish, since they changed slightly
between Android 15 and Android 16.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Update the android container to include all of the packages, tools, and
tests that are up-to-date with Android 16.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Update the aospless container to work with the Android 16 repositories.
This ensures that aospless can still be used to build drm-hwcomposer
binaries for Android 16.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Build the cuttlefish device for Android 16. This keeps CI coverage
as complete and up-to-date as possible.
Since Android 16 deprecates builds with make, temporarily stop using mesa
libraries with the intention of adding a Soong build of mesa in the
future.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
In preparation for rebuilding all CI containers to use Android 16,
update CI/build variables to use Android 16 and Android SDK 36.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
When $FDO_CI_BASH_HELPERS was added, it included an ERR trap that is
triggered when a cts failure is found in the invocation summary. This
prevents the full cts logs from being saved in the job results.
Revise the cts failure check to avoid triggering the trap on error and
allow the full cts logs to be saved.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Since libbase is now part of hwcomposer.drm_defaults, meson builds also
need the `base` dependency to avoid linking errors.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Currently the clang-tidy CI job is ignoring code guarded by
`__ANDROID_API__ >= 36` so some readability warnings slipped through.
In preparation for updating the ANDROID_SDK_VERSION to 36, silence these
warnings:
* error: invalid case style for parameter 'maxProfiles'
* error: all parameters should be named in a function
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Call this from the Backend when testing a composition. Future commit
will make this a const function to indicate that it doesn't change
HwcDisplay internal state.
Change-Id: I9bd6962e213acd76d13afbdc620418bd1ff95557
Backend shouldn't directly mutate HwcLayer state, so make HwcLayer
const. Make a few other related functions const correct as well.
Change-Id: Id7f8e255e9e72b756399b1a4dabc3db779d64bc9
Rename to GetCompositionTypes to reflect that the function is no longer
setting HwcLayer state (marking). Also make the input |layers| const
since it's no longer being modified.
Change-Id: I53702a6df680b9a138bb16191a3cac0b17e4b632
Rather than setting the ValidatedType on the layers directly from the
Backend, return the per-layer composition type decisions from the
Backend and let the HwcDisplay set it.
This is a step towards the goal of not setting HwcLayer state directly
from the Backend.
Change-Id: I8e2d1e7c6fb0d9071d5dca101ddb455b95535bd0
Explicitly set DerivePointerAlignment: true to avoid spurious
clang-format corrections and keep the project consistent with itself.
Change-Id: I2928adebf8c56743ffe910f5026d501beda8941f
GetDisplayConfigurations_hasHdrType fails for headless displays since
the hdrOutputType is not initialized for fake modes. Set fake modes to
kSystem instead of kInvalid.
Change-Id: I051dc742b4786bbb0bf8a9384a6d3cde536eebce
IsWriteBackSupported is called on a display as part of
getReadbackBufferAttributes. If this is called on a headless display,
then it will result in a null ptr dereference.
Check for headless display and return 'false' in this case.
Change-Id: Ia492dec338ab65457670e3b22c2e8582031aa129
A test commit or failed modesets, particularly when with modes of a
different resolution, would cause all subsequent pafe-flip commits to
fail.
The root cause was a premature state update within
SetDisplayModeIfNeeded. The `whole_display_rect_` member was being
modified during the commit preparation phase. This polluted the state
manager's internal view of the active display size, causing subsequent
frame compositions to be built with incorrect dimensions, which were
then rejected by the kernel on certain drivers that cannot handle
scaling on the fly.
This change fixes the issue by deferring the state update until after a
commit is successfully applied:
1. `whole_display_rect_` is now only updated inside `CommitFrame` after
a modesetting commit has been successfully applied to hardware.
2. `SetCompositionIfNeeded` is updated to use the dimensions from the
incoming `args.display_mode`, if available, when preparing a modeset.
Otherwise it will use the existing size in `whole_display_rect_`.
This ensures the plane is correctly configured for either the
requested mode, or the currently active one (for page-flips).
This prevents test-only operations from having side effects and ensures
the state manager's internal state remains consistent. It also prevents
state pollution on failed modesets.
Change-Id: Icf08b32c13879d394f883f34e6fed3d96a748a4f
Co-authored-by: Lucas Berthou <berlu@google.com>
Signed-off-by: Gil Dekel <gildekel@google.com>
CalcPixOps determines the cost of GPU-composition over a range
of layers. This change removes cursor-specific logic that was
accounting for behavior that only applies when the cursor is
not GPU-composited. This change restores the standard logic,
so that the cost of GPU-compositing the cursor layer is corrected.
Change-Id: I310fd35e2cd4f4df6d334ae0d989f2298267323a
Currently the seamless modeset test will segfault when attempting to
access the connector for a display running in headless mode.
Skip the seamless test if the display is running in headless mode.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Configuration groups for the Multiple Refresh Rate (MRR) feature support
is currently disabled in DRM HWComposer. This is because it is
insufficient to group modes solely based on their active region size.
The primary reasons for this insufficiency are:
1. drm-hwc clients may assume they can seamlessly switch between
configurations within the same group to support variable refresh
rates.
2. Not all System-on-a-Chip (SoC) architectures support seamless mode
transitions.
3. For SoCs that do support seamless switching, transitions often depend
on other hardware-specific properties like matching blanking periods.
4. A fallback to a non-seamless (blocking) modeset is unacceptable for
internal displays if a seamless transition fails, as this causes
flickering. The current framework does not handle such failures
gracefully.
To Resolve these challenges and re-enable seamless Multiple Refresh-Rate
transitions on internal panels, we add logic to validate all configs
against the preferred initial active config. This validation preforms a
seamless modeset test on each available config against the config that
was set during the display initialization. Configs that fail the
screening are assigned new group IDs.
Caveats:
1. Currently, this is only implemented for internal panels. External
display seamless transition between variable refresh rates is not
support. However this work can be extended to support seamless
transitions on external displays as well.
2. Grouping is only preformed for the preffered/active config at the
time of display init, and is valid only for the duration of the
current full modeset commit. No other groups are not created (since
they cannot be validated), and any new full commits will not honor
the guarantee provided by the check. This work can be extended to
refresh and validate all configs within the same group ID of any
incoming full modeset commit.
Change-Id: Ie2661e74bd3ff704b40c8c7ef50c56e604e5e8df
Signed-off-by: Gil Dekel <gildekel@google.com>
At some point, probably when migrating to hwc3 and creating/refactoring
HwcDisplay, we stopped pruning disabled configs before returning them
via GetDisplayConfigs().
Ensure disabled configs are pruned if disabled.
Change-Id: Iae3600d5e9b84cb3bb724949da82d42d5b801acd
Signed-off-by: Gil Dekel <gildekel@google.com>
The `future_config` feature is not currently used, and incoming changes
will most likely dub it obsolete. Removing it and making QueueConfig
always seamless makes more sense.
In addition, try to always queue a seamless config first, adding it to
the next pageflip commit to reduce jank. If seamless is not allowed (no
active mode or the new config is not within the same group_id, fallback
to a full blocking modeset commit.
Change-Id: I64dec41a93ba4f29bee501f7227b6f6961c9eb44
Signed-off-by: Gil Dekel <gildekel@google.com>
Error codes are never checked and working with errors as booleans
results in somewhat counter-intuitive logic.
Change CommitFrame() and ExecuteAtomicCommit() to return bools instead.
Change-Id: I5e8041fd4ddc99ef06184081a7f6def028bbe356
Signed-off-by: Gil Dekel <gildekel@google.com>
