No description
ad29efaa71
For all current ChromeOS boards, MTL and older, this patch should change
no behavior. It's just a refactor.
Do not choose at buildtime based on macro definitions. Decisions about
scanout-capable modifiers should be decided at runtime based on chipset
info.
We can safely delete the #ifdef blocks for I915_SCANOUT_4_TILED and
I915_SCANOUT_Y_TILED without changing any behavior. They were controlled
by the ebuild snippet below, and the USE flag is set if and only if
chipset >= MTL.
if use intel_drm_tile4 ; then
append-cppflags -DI915_SCANOUT_4_TILED
else
append-cppflags -DI915_SCANOUT_Y_TILED
fi
I tested the patch on rex (MTL) and brya (ADL), which pre-patch took
different #ifdef paths. Before and after the patch, On MTL, I confirmed
that fullscreen video from https://crosvideo.appspot.com/?codec=h264 was
promoted to a scanout plane with the expected pixel format and modifier:
I915_FORMAT_MOD_4_TILED + DRM_FORMAT_NV12. On ADL, I confirmed the same
for I915_FORMAT_MOD_Y_TILED + DRM_FORMAT_NV12. I confirmed by inspecting
/sys/kernel/debug/dri/0/state during video playback.
BUG=b:349135555
TEST=brya, rex. Confirm fullscreen h264 video gets promoted to scanout
plane with correct pixel format and modifier. See commit message.
Change-Id: I1c5155548287869279fec3aa0b02e057acc788fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/6082999
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Marcin Wojtas <mwojtas@google.com>
Tested-by: Lina Versace <linyaa@google.com>
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com>
Auto-Submit: Lina Versace <linyaa@google.com>
|
||
|---|---|---|
| cros_gralloc | ||
| external | ||
| .clang-format | ||
| amdgpu.c | ||
| backend_mock.c | ||
| common.mk | ||
| DIR_METADATA | ||
| dri.c | ||
| dri.h | ||
| drv.c | ||
| drv.h | ||
| drv_array_helpers.c | ||
| drv_array_helpers.h | ||
| drv_helpers.c | ||
| drv_helpers.h | ||
| drv_priv.h | ||
| dumb_driver.c | ||
| gbm.c | ||
| gbm.h | ||
| gbm_helpers.c | ||
| gbm_helpers.h | ||
| gbm_priv.h | ||
| gbm_unittest.cc | ||
| i915.c | ||
| LICENSE | ||
| Makefile | ||
| mediatek.c | ||
| minigbm_helpers.c | ||
| minigbm_helpers.h | ||
| msm.c | ||
| OWNERS | ||
| PRESUBMIT.cfg | ||
| presubmit.sh | ||
| rockchip.c | ||
| testrunner.cc | ||
| util.h | ||
| vc4.c | ||
| virtgpu.c | ||
| virtgpu.h | ||
| virtgpu_cross_domain.c | ||
| virtgpu_virgl.c | ||