Previous change introduced a regression to CTS tests on other mediatek
board then MTK8173. This CL fixes this by switching to relying on
MTK_MT8173 compile define.
BUG=b:305347887
TEST=android.mediav2.cts.CodecEncoderSurfaceTest
Cq-Depend: chromium:4887244
Change-Id: I30f814222423e1b77d25c3256e9fcb0319c6339f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4946471
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Bartłomiej Grzesik <bgrzesik@google.com>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
am skip reason: Merged-In I361358bc495270c85e00f61041e2eb4f172d8a6f with SHA-1 31140885b6 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2824252
Change-Id: I276d92d808f0efedf520a01d4275ed8ad020a769
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I361358bc495270c85e00f61041e2eb4f172d8a6f with SHA-1 dffb72afb3 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2824252
Change-Id: Ic647e70f57c560a1c129682059f9297d696bbc5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I361358bc495270c85e00f61041e2eb4f172d8a6f with SHA-1 31140885b6 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/minigbm/+/2824252
Change-Id: Ie128c6c13a6844dedc7133676adff0f61ebfbf9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
When MINIGBM_DEBUG=log_bos is set, log all bos created/imported.
BUG=none
TEST=add MINIGBM_DEBUG=log_bos to /etc/chrome_dev.conf and
see logs in /var/log/ui/ui.LATEST
Change-Id: Ib2b2d5c3181862b557dbc5499fef84f2c9ac8122
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/5014198
Commit-Queue: ChromeOS Auto Retry <chromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: Dawn Han <dawnhan@google.com>
Tested-by: Chia-I Wu <olv@google.com>
Needed to make crosvm vendor available
Bug: 309149829
Test: build aosp_cf_x86_64_phone_trusty_vm-userdebug
Change-Id: I1872e332d907035acd914d50919461ac59405b68
This patch fixes the allocation of BO_USE_HW_VIDEO_DECODER | BO_USE_HW_VIDEO_ENCODER
on MTK8173 in order to pass CTS tests. The tests were failing due to
lack of resolved combo for DRM_FORMAT_FLEX_YCbCr_420_888 with
BO_USE_HW_VIDEO_DECODER | BO_USE_HW_VIDEO_ENCODER. Furthermore a change in
buffer alignment was required to avoid V4L2VDA failures.
BUG=b:292507490
TEST=CtsMediaV2TestCases android.mediav2.cts.CodecEncoderSurfaceTest
Change-Id: I41170169098e9110154328288710832a436bc9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4916803
Auto-Submit: Bartłomiej Grzesik <bgrzesik@google.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Bartłomiej Grzesik <bgrzesik@google.com>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Previously, when the environment variable is not found, IOW when the
feature flag does not set the value for the variable,
|enable_intel_media_compression_var| is NULL and minigbm would log about
this. This would create noise in the log, especially when
`drv->compression` is not true or when the feature flag has not landed.
This CL makes change to only log about the failure to get the
environment variables for Media compression support if
`drv->compression == true`.
Change-Id: Ia6d33b08759d4fe94f2bc8de3fb99287748442b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4919324
Tested-by: Hang Nguyen <hnt@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@google.com>
Reviewed-by: Nathan Hebert <nhebert@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Commit-Queue: Hang Nguyen <hnt@chromium.org>
This CL removes the combination of having media compressed buffers for
hardware protected content. The current API does not allow the support
for dma-bufs with protected content in libva.
BUG=b:201620358, b:289449755
TEST=Run the video.PlayDRM.* test on Chrome with feature flag enabled
for MMC and verify that no compressed buffer is allocated in the output
of below command:
localhost ~ # cat /sys/kernel/debug/dri/0/i915_gem_framebuffer
user size: 854 x 480, depth 0, 8 bpp, modifier 0x100000000000002
Change-Id: Ib5850d68a36556195110aaae1419a4fb51ecca53
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4887518
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Hang Nguyen <hnt@chromium.org>
Tested-by: Hang Nguyen <hnt@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@google.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
... to pull in https://crrev.com/c/4897926.
Bug: b/300616292
Bug: b/300194143
Bug: b/294661992
Test: launch Cuttlefish, run SurfaceFlinger_test, inspect
tracing around lifetime of cros_gralloc_driver
Change-Id: I72c9164c2194af87bab0800fd821b4bc0934f245
... to ensure the lifetime of the underlying cros_gralloc_driver
matches those of the various Mapper* interfaces. Without this, the
the destruction of the static cros_gralloc_driver `s_instance`
could race with a potential CrosGralloc4Mapper user on another
thread which is still alive at the time of exit() (for example,
a buffer being cleaned up on a libhwbinder worker thread).
Bug: b/300616292
Bug: b/300194143
Bug: b/294661992
Test: launch Cuttlefish, run SurfaceFlinger_test, inspect
tracing around lifetime of cros_gralloc_driver
Change-Id: Id8e2dbff471c03f7b663952524905a06cc03fbc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4897926
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Tested-by: Jason Macnak <natsu@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>
From Gen-12 onwards Media compression aux buffer layout has been
changed. The functionality to allocate minigbm compressed buffers are
mostly taken from CL:3275292 and this CL adapts it to guard this
feature behind an environment variable controlled by the minigbm user
application (we're not re-using the original CL because it seems the
original author is no longer active).
BUG=b:201620358
TEST=Play video on Chrome with feature flag enabled for MMC and verify
type (7) of buffer modifer in the output of below command:
localhost ~ # cat /sys/kernel/debug/dri/0/i915_gem_framebuffer
user size: 1280 x 720, depth 0, 8 bpp, modifier 0x100000000000007
Change-Id: I69cb527eb9d16498f7e9c2fb32c793cea6b6a4ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4655427
Reviewed-by: Andres Calderon Jaramillo <andrescj@google.com>
Commit-Queue: Hang Nguyen <hnt@chromium.org>
Tested-by: Hang Nguyen <hnt@chromium.org>
I will soon change my LDAP. Prepare for the change by adding linyaa@ to
each OWNERS file that contains chadversary@.
BUG=b:295079822
TEST=CQ
Change-Id: I23d206e233559bae25396b8ea9714e081a8cae31
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4854085
Reviewed-by: Chia-I Wu <olv@google.com>
Commit-Queue: Chia-I Wu <olv@google.com>
Auto-Submit: Lina Versace <linyaa@google.com>
Tested-by: Lina Versace <linyaa@google.com>
