lineage-rockchip/android_external_minigbm
1
0
Fork 0
Code Activity Actions

mediatek: allow DRM_FORMAT_YVU420_ANDROID for camera use

Browse source 
After this change is_supported() succeeds, USB camera starts
working and:

 E [minigbm:CrosGralloc4Allocator.cc(88)]: Unsupported combination -- pixel format: YV12, drm format:DRM_FOURCC_9997, usage: CPU_READ_NEVER | CPU_WRITE_NEVER | CPU_WRITE_RARELY | CPU_WRITE_OFTEN | GPU_TEXTURE | CAMERA_OUTPUT (0x20130)

issue is fixed.

Similar settings were already introduced for other backends e.g. msm:
https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3058396

BUG=b:320202326, b:309244873
Test: Verify that external USB camera is working in Android environment

Change-Id: I7e1e328998ddf62ed127c001f054ed10c6fb6a02
Reviewed-by: Michal Dubiel <dubielm@google.com>
Reviewed-by: Konrad Adamczyk <konrada@google.com>
Tested-by: Konrad Adamczyk <konrada@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/5913519
Auto-Submit: Grzegorz Jaszczyk <jaszczyk@google.com>
Tested-by: Grzegorz Jaszczyk <jaszczyk@google.com>
Commit-Queue: Grzegorz Jaszczyk <jaszczyk@google.com>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
This commit is contained in:
Grzegorz Jaszczyk 2024-01-15 11:36:49 +00:00 • committed by Chromeos LUCI
parent 6d687b7b62
commit ff0509d723
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
mediatek.c
View file

@ -201,6 +201,13 @@ static int mediatek_init(struct driver *drv)
BO_USE_SCANOUT | BO_USE_HW_VIDEO_ENCODER | BO_USE_CAMERA_READ |
BO_USE_CAMERA_WRITE);
/*
* Android also frequently requests YV12 formats for some camera implementations
* (including the external provider implmenetation).
*/
drv_modify_combination(drv, DRM_FORMAT_YVU420_ANDROID, &metadata,
BO_USE_CAMERA_WRITE);
#ifdef MTK_MT8183
/* Only for MT8183 Camera subsystem */
drv_modify_combination(drv, DRM_FORMAT_NV21, &metadata,