lineage-rockchip/android_external_minigbm
1
0
Fork 0
Code Activity Actions

mediatek: Exclude MT8173's FP16 and 10-bit ABGR support

Browse source 
MT8173's IMG driver doesn't seem to support these texture formats, and
that causes CTS failures when we upgrade Android version to container-R.
Use an allow-list approach to exclude the formats from MT8173.

While at it, also do a minor renaming for alignment.

BUG=b:278492435
TEST=CtsGraphicsTestCases

Change-Id: Ic7ce5510f986c4cf3176b72a5f196b648387de34
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4453148
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Tested-by: Fei Shao <fshao@chromium.org>
Commit-Queue: Fei Shao <fshao@chromium.org>
This commit is contained in:
Fei Shao 2023-04-20 18:49:06 +08:00 • committed by Chromeos LUCI
parent 5d2a76894d
commit eb1d691736
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
mediatek.c
View file

@ -29,10 +29,11 @@
#if defined(MTK_MT8183) || \
defined(MTK_MT8186)
// clang-format on
#define SUPPORTS_YUV422
#define SUPPORT_YUV422
#endif
// All platforms except MT8173 should USE_NV12_FOR_HW_VIDEO_DECODING.
// All platforms except MT8173 should USE_NV12_FOR_HW_VIDEO_DECODING
// and SUPPORT_FP16_AND_10BIT_ABGR
// clang-format off
#if defined(MTK_MT8183) || \
defined(MTK_MT8186) || \
@ -41,6 +42,7 @@
defined(MTK_MT8195)
// clang-format on
#define USE_NV12_FOR_HW_VIDEO_DECODING
#define SUPPORT_FP16_AND_10BIT_ABGR
#else
#define DONT_USE_64_ALIGNMENT_FOR_VIDEO_BUFFERS
#endif
@ -65,12 +67,14 @@ static const uint32_t render_target_formats[] = { DRM_FORMAT_ABGR8888, DRM_FORMA
// clang-format off
static const uint32_t texture_source_formats[] = {
#ifdef SUPPORTS_YUV422
#ifdef SUPPORT_YUV422
DRM_FORMAT_NV21,
DRM_FORMAT_YUYV,
#endif
#ifdef SUPPORT_FP16_AND_10BIT_ABGR
DRM_FORMAT_ABGR2101010,
DRM_FORMAT_ABGR16161616F,
#endif
DRM_FORMAT_NV12,
DRM_FORMAT_YVU420,
DRM_FORMAT_YVU420_ANDROID
@ -226,7 +230,7 @@ static int mediatek_bo_create_with_modifiers(struct bo *bo, uint32_t width, uint
const bool is_format_yv12 =
format == DRM_FORMAT_YVU420 || format == DRM_FORMAT_YVU420_ANDROID;
#endif
#ifdef SUPPORTS_YUV422
#ifdef SUPPORT_YUV422
/*
* JPEG Encoder Accelerator requires 16x16 alignment. We want the buffer
* from camera can be put in JEA directly so align the height to 16