lineage-rockchip/android_external_minigbm
1
0
Fork 0
Code Activity Actions

virtgpu_crosdomain: add metadata_cache_lock

Browse source 
crosdomain specific metadata_cache should be protected by a backend
specific lock to reduce lock contention.

BUG=b:201110412
TEST=CQ

Change-Id: Ic3cedd7ad7903e669f7fba2b5f45d88739fbdc97
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3188471
Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
Tested-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Chia-I Wu <olv@google.com>
This commit is contained in:
Yiwei Zhang 2021-09-27 19:58:56 +00:00 • committed by Commit Bot
parent afdf87dcd4
commit e12d3ae83d
2 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
drv_priv.h
View file

@ -71,7 +71,6 @@ struct driver {
* The driver_lock currently protects:
* 1. buffer_table
* 2. mappings
* 3. metadata_cache in virtgpu_cros_domain
*/
pthread_mutex_t driver_lock;
bool compression;

17
virtgpu_cross_domain.c
View file

@ -36,6 +36,7 @@ struct cross_domain_private {
uint32_t ring_handle;
void *ring_addr;
struct drv_array *metadata_cache;
pthread_mutex_t metadata_cache_lock;
};
static void cross_domain_release_private(struct driver *drv)
@ -57,7 +58,11 @@ static void cross_domain_release_private(struct driver *drv)
}
}
drv_array_destroy(priv->metadata_cache);
if (priv->metadata_cache)
drv_array_destroy(priv->metadata_cache);
pthread_mutex_destroy(&priv->metadata_cache_lock);
free(priv);
}
@ -150,7 +155,7 @@ static int cross_domain_metadata_query(struct driver *drv, struct bo_metadata *m
uint32_t plane, remaining_size;
memset(&cmd_get_reqs, 0, sizeof(cmd_get_reqs));
pthread_mutex_lock(&drv->driver_lock);
pthread_mutex_lock(&priv->metadata_cache_lock);
for (uint32_t i = 0; i < drv_array_size(priv->metadata_cache); i++) {
cached_data = (struct bo_metadata *)drv_array_at_idx(priv->metadata_cache, i);
if (!metadata_equal(metadata, cached_data))
@ -203,7 +208,7 @@ static int cross_domain_metadata_query(struct driver *drv, struct bo_metadata *m
drv_array_append(priv->metadata_cache, metadata);
out_unlock:
pthread_mutex_unlock(&drv->driver_lock);
pthread_mutex_unlock(&priv->metadata_cache_lock);
return ret;
}
@ -246,6 +251,12 @@ static int cross_domain_init(struct driver *drv)
if (!priv)
return -ENOMEM;
ret = pthread_mutex_init(&priv->metadata_cache_lock, NULL);
if (!ret) {
free(priv);
return ret;
}
priv->metadata_cache = drv_array_init(sizeof(struct bo_metadata));
if (!priv->metadata_cache) {
ret = -ENOMEM;