lineage-rockchip/android_external_minigbm
1
0
Fork 0
Code Activity Actions

minigbm: consistent style

Browse source 
- Sometimes were return -1 and sometimes -errno.  Prefer -errno
  wherever possible.
- No braces for single line if/else statements.  This does not
  apply gralloc3/gralloc4, since that directory follows AOSP
  style.

BUG=b:178495907
TEST=Cuttlefish CFI

Change-Id: I4c35768e015109730772a972b4b18e8d2c3cbb9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/2665001
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Jason Macnak <natsu@google.com>
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
This commit is contained in:
Gurchetan Singh 2021-02-01 12:03:11 -08:00 • committed by Commit Bot
parent 52155b4b57
commit cadc54fe5d
13 changed files with 59 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

6
minigbm_helpers.c
View file

@ -62,7 +62,7 @@ static int fd_node_num(int fd)
dri_node_size = readlink(fd_path, dri_node, sizeof(dri_node));
if (dri_node_size < 0)
return -1;
return -errno;
dri_node[dri_node_size] = '\0';
return dri_node_num(dri_node);
}
@ -223,7 +223,7 @@ PUBLIC int gbm_get_default_device_fd(void)
dir = opendir("/dev/dri");
if (!dir)
return -1;
return -errno;
fd = -1;
while ((dir_ent = readdir(dir))) {
@ -307,7 +307,7 @@ PUBLIC int gbm_detect_device_info_path(unsigned int detect_flags, const char *de
info->dri_node_num + 128);
fd = open(rendernode_name, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK);
if (fd < 0)
return -1;
return -errno;
ret = detect_device_info(detect_flags, fd, info);
close(fd);
return ret;