From a845b4c1576105573ae3ea3c414d903af9b684c0 Mon Sep 17 00:00:00 2001 From: Dawn Han Date: Fri, 3 Mar 2023 18:43:31 +0000 Subject: [PATCH] minigbm: clean up legacy gbm_get_default_device_fd usage `gbm_get_default_device_fd` is no longer used externally. It became a helper function for `minigbm_create_default_device`. So we are no longer need to expose it as PUBLIC. BUG=b:267219693 TEST=manual check that the function works Change-Id: I7109f27e843ee6a86e998c1dc9c2f2a5ff807997 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4308055 Commit-Queue: Dawn Han Tested-by: Dawn Han Reviewed-by: Yiwei Zhang --- minigbm_helpers.c | 2 +- minigbm_helpers.h | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/minigbm_helpers.c b/minigbm_helpers.c index b3471e5..d1da7c4 100644 --- a/minigbm_helpers.c +++ b/minigbm_helpers.c @@ -211,7 +211,7 @@ done: return 0; } -PUBLIC int gbm_get_default_device_fd(void) +static int gbm_get_default_device_fd(void) { DIR *dir; int ret, fd, dfd = -1; diff --git a/minigbm_helpers.h b/minigbm_helpers.h index 500d97e..dbbb644 100644 --- a/minigbm_helpers.h +++ b/minigbm_helpers.h @@ -36,13 +36,7 @@ int gbm_detect_device_info_path(unsigned int detect_flags, const char *dev_node, struct gbm_device_info *info); /* - * Select "default" device to use for graphics memory allocator. - */ -int gbm_get_default_device_fd(void); - -/* - * Create "default" gbm device. This can pick a different DRM device than - * gbm_get_default_device_fd and should be preferred in most cases. + * Create "default" gbm device. */ struct gbm_device *minigbm_create_default_device(int *out_fd);