lineage-rockchip/android_external_minigbm
1
0
Fork 0
Code Activity Actions

minigbm: Align stride to 512 for multiplane formats

Browse source 
This was restricted to Raven. Modify that restriction so that this
happens for Stoney as well. It seems that Stoney is also affected by
this same issue, but it just didn't cause any CTS or other errors until
the mesa-amd uprev added some additional correctness checks.

TEST=android.media.cts.EncodeDecodeTest passes on grunt
BUG=b:190484589

Change-Id: Ieebbffb0d711d08c24c071e79c0b3224663c8369
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3060894
Reviewed-by: Bas Nieuwenhuizen <basni@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
This commit is contained in:
Drew Davenport 2021-07-29 19:52:02 -06:00 • committed by Commit Bot
parent 2e63aaf616
commit 49b804b11a
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
amdgpu.c
View file

@ -443,9 +443,9 @@ static int amdgpu_create_bo_linear(struct bo *bo, uint32_t width, uint32_t heigh
* For multiplane formats, align the stride to 512 to ensure that subsample strides are 256
* aligned. This uses more memory than necessary since the first plane only needs to be
* 256 aligned, but it's acceptable for a short-term fix. It's probably safe for other gpu
* families, but let's restrict it to Raven for now (b/171013552).
* families, but let's restrict it to Raven and Stoney for now (b/171013552, b/190484589).
* */
if (priv->dev_info.family == AMDGPU_FAMILY_RV && num_planes > 1)
if (priv->dev_info.family <= AMDGPU_FAMILY_RV && num_planes > 1)
stride = ALIGN(stride, 512);
else
stride = ALIGN(stride, 256);