lineage-rockchip/android_external_minigbm
1
0
Fork 0
Code Activity Actions

minigbm: Use DRM_IOCTL_I915_GEM_MMAP_OFFSET on MTL

Browse source 
mmap ioctl is disallowed for all discrete platforms and for all
platforms with GRAPHICS_VER > 12.
Refer: https://patchwork.freedesktop.org/patch/440915/

BUG=b:266001234
TEST=Photo capture on camera

Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Change-Id: I2151f56a6e32217a30783b10b3edfa915773316e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/4179852
Tested-by: Arselan Alvi <arselan.alvi@intel.com>
Reviewed-by: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Matt Turner <msturner@google.com>
This commit is contained in:
Sushma Venkatesh Reddy 2023-02-15 10:53:44 -08:00 • committed by Chromeos LUCI
parent 9f36afc60a
commit 46a3cfa5a8
1 changed files with 54 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

81
i915.c
View file

@ -62,6 +62,7 @@ struct i915_device {
/*TODO : cleanup is_mtl to avoid adding variables for every new platforms */
bool is_mtl;
int32_t num_fences_avail;
bool has_mmap_offset;
};
static void i915_info_from_device_id(struct i915_device *i915)
@ -412,7 +413,7 @@ static void i915_clflush(void *start, size_t size)
static int i915_init(struct driver *drv)
{
int ret;
int ret, val;
struct i915_device *i915;
drm_i915_getparam_t get_param = { 0 };
@ -449,9 +450,22 @@ static int i915_init(struct driver *drv)
ret = drmIoctl(drv->fd, DRM_IOCTL_I915_GETPARAM, &get_param);
if (ret) {
drv_loge("Failed to get I915_PARAM_NUM_FENCES_AVAIL\n");
free(i915);
return -EINVAL;
}
memset(&get_param, 0, sizeof(get_param));
get_param.param = I915_PARAM_MMAP_GTT_VERSION;
get_param.value = &val;
ret = drmIoctl(drv->fd, DRM_IOCTL_I915_GETPARAM, &get_param);
if (ret) {
drv_loge("Failed to get I915_PARAM_MMAP_GTT_VERSION\n");
free(i915);
return -EINVAL;
}
i915->has_mmap_offset = (val >= 4);
if (i915->graphics_version >= 12)
i915->has_hw_protection = 1;
@ -803,6 +817,7 @@ static void *i915_bo_map(struct bo *bo, struct vma *vma, size_t plane, uint32_t
{
int ret;
void *addr = MAP_FAILED;
struct i915_device *i915 = bo->drv->priv;
if ((bo->meta.format_modifier == I915_FORMAT_MOD_Y_TILED_CCS) ||
(bo->meta.format_modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS) ||
@ -810,34 +825,46 @@ static void *i915_bo_map(struct bo *bo, struct vma *vma, size_t plane, uint32_t
return MAP_FAILED;
if (bo->meta.tiling == I915_TILING_NONE) {
struct drm_i915_gem_mmap gem_map = { 0 };
/* TODO(b/118799155): We don't seem to have a good way to
* detect the use cases for which WC mapping is really needed.
* The current heuristic seems overly coarse and may be slowing
* down some other use cases unnecessarily.
*
* For now, care must be taken not to use WC mappings for
* Renderscript and camera use cases, as they're
* performance-sensitive. */
if ((bo->meta.use_flags & BO_USE_SCANOUT) &&
!(bo->meta.use_flags &
(BO_USE_RENDERSCRIPT | BO_USE_CAMERA_READ | BO_USE_CAMERA_WRITE)))
gem_map.flags = I915_MMAP_WC;
if (i915->has_mmap_offset) {
struct drm_i915_gem_mmap_offset gem_map = { 0 };
gem_map.handle = bo->handles[0].u32;
gem_map.flags = I915_MMAP_OFFSET_WB;
gem_map.handle = bo->handles[0].u32;
gem_map.offset = 0;
gem_map.size = bo->meta.total_size;
/* Get the fake offset back */
ret = drmIoctl(bo->drv->fd, DRM_IOCTL_I915_GEM_MMAP_OFFSET, &gem_map);
if (ret == 0)
addr = mmap(0, bo->meta.total_size, drv_get_prot(map_flags), MAP_SHARED,
bo->drv->fd, gem_map.offset);
} else {
struct drm_i915_gem_mmap gem_map = { 0 };
/* TODO(b/118799155): We don't seem to have a good way to
* detect the use cases for which WC mapping is really needed.
* The current heuristic seems overly coarse and may be slowing
* down some other use cases unnecessarily.
*
* For now, care must be taken not to use WC mappings for
* Renderscript and camera use cases, as they're
* performance-sensitive. */
if ((bo->meta.use_flags & BO_USE_SCANOUT) &&
!(bo->meta.use_flags &
(BO_USE_RENDERSCRIPT | BO_USE_CAMERA_READ | BO_USE_CAMERA_WRITE)))
gem_map.flags = I915_MMAP_WC;
ret = drmIoctl(bo->drv->fd, DRM_IOCTL_I915_GEM_MMAP, &gem_map);
/* DRM_IOCTL_I915_GEM_MMAP mmaps the underlying shm
* file and returns a user space address directly, ie,
* doesn't go through mmap. If we try that on a
* dma-buf that doesn't have a shm file, i915.ko
* returns ENXIO. Fall through to
* DRM_IOCTL_I915_GEM_MMAP_GTT in that case, which
* will mmap on the drm fd instead. */
if (ret == 0)
addr = (void *)(uintptr_t)gem_map.addr_ptr;
gem_map.handle = bo->handles[0].u32;
gem_map.offset = 0;
gem_map.size = bo->meta.total_size;
ret = drmIoctl(bo->drv->fd, DRM_IOCTL_I915_GEM_MMAP, &gem_map);
/* DRM_IOCTL_I915_GEM_MMAP mmaps the underlying shm
* file and returns a user space address directly, ie,
* doesn't go through mmap. If we try that on a
* dma-buf that doesn't have a shm file, i915.ko
* returns ENXIO. Fall through to
* DRM_IOCTL_I915_GEM_MMAP_GTT in that case, which
* will mmap on the drm fd instead. */
if (ret == 0)
addr = (void *)(uintptr_t)gem_map.addr_ptr;
}
}
if (addr == MAP_FAILED) {