From 04c8f511449d4ebe714d293b09e434d7295981e4 Mon Sep 17 00:00:00 2001 From: Jason Macnak Date: Wed, 29 Sep 2021 11:38:00 -0700 Subject: [PATCH] drv: fix unused variable external/minigbm/drv.c:404:7: error: unused variable 'ret' int ret = drv_bo_mapping_destroy(bo); ^ BUG=b:201325625 TEST=build latest in AOSP Change-Id: I4070419aeae4054ed3eda084b810a3143a41b74f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3194819 Reviewed-by: Yiwei Zhang Tested-by: Jason Macnak Commit-Queue: Yiwei Zhang --- drv.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drv.c b/drv.c index 7fc5ea7..b50eea6 100644 --- a/drv.c +++ b/drv.c @@ -241,7 +241,7 @@ struct bo *drv_bo_new(struct driver *drv, uint32_t width, uint32_t height, uint3 return bo; } -static int drv_bo_mapping_destroy(struct bo *bo) +static void drv_bo_mapping_destroy(struct bo *bo) { struct driver *drv = bo->drv; uint32_t idx = 0; @@ -264,7 +264,7 @@ static int drv_bo_mapping_destroy(struct bo *bo) int ret = drv->backend->bo_unmap(bo, mapping->vma); if (ret) { drv_log("munmap failed\n"); - return ret; + return; } free(mapping->vma); @@ -275,8 +275,6 @@ static int drv_bo_mapping_destroy(struct bo *bo) } } pthread_mutex_unlock(&drv->mappings_lock); - - return 0; } /* @@ -401,9 +399,7 @@ struct bo *drv_bo_create_with_modifiers(struct driver *drv, uint32_t width, uint void drv_bo_destroy(struct bo *bo) { if (!bo->is_test_buffer && drv_bo_release(bo)) { - int ret = drv_bo_mapping_destroy(bo); - assert(ret == 0); - + drv_bo_mapping_destroy(bo); bo->drv->backend->bo_destroy(bo); }