From ee1b1e4a60b771a8927644f74807a98b55968c65 Mon Sep 17 00:00:00 2001 From: Simon Perretta Date: Wed, 10 Sep 2025 15:32:02 +0100 Subject: [PATCH] pco/ra: properly handle non-dced instrs with unused defs Signed-off-by: Simon Perretta Acked-by: Erik Faye-Lund Part-of: --- src/imagination/pco/pco_ra.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/imagination/pco/pco_ra.c b/src/imagination/pco/pco_ra.c index ce726130b3b..5f355363a5f 100644 --- a/src/imagination/pco/pco_ra.c +++ b/src/imagination/pco/pco_ra.c @@ -731,6 +731,14 @@ static bool pco_ra_func(pco_func *func, pco_ra_ctx *ctx) } } + /* If there are instructions left with any unused dests that aren't/couldn't + * be DCEd (e.g. because of side effects), ensure their range ends are setup + * to avoid missing overlaps and clobbering regs. + */ + for (unsigned var = 0; var < num_vars; ++var) + if (live_ranges[var].start != ~0U && live_ranges[var].end == 0) + live_ranges[var].end = live_ranges[var].start; + /* Build interference graph from overlapping live ranges. */ for (unsigned var0 = 0; var0 < num_vars; ++var0) { for (unsigned var1 = var0 + 1; var1 < num_vars; ++var1) {