Shared state is protected by a combination of the local mutex_ and the global lock. This change attempts to document and enforce that more clearly using clang-tidy thread annotations. Change unique_lock usage to lock_guard for cases that do not require release of the mutex such as when using a condition variable. Temporarily add a main_lock_ mutex which mirrors how the global lock is being used for synchronization. Lock this at the entry point to all public methods. This lock will be removed as a part of subsequent refactoring and it used to more cleanly break up the following changes in this series. Some state is not properly protected by any lock, so temporarily disable the warnings around access to that state until the synchronization is resolved in subsequent changes. Change-Id: I6f4f30c4e97f266146b0879c5255d6f2432f12a3 |
||
|---|---|---|
| .ci | ||
| backend | ||
| bufferinfo | ||
| compositor | ||
| drm | ||
| hwc | ||
| hwc2_device | ||
| hwc3 | ||
| stats | ||
| tests | ||
| utils | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| Android.bp | ||
| Makefile | ||
| meson.build | ||
| MODULE_LICENSE_APACHE2 | ||
| NOTICE | ||
| README.md | ||
drm_hwcomposer
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
-
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
-
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
-
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file -
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!