Currently, drm_hwcomposer has two main ways to lock up in the composition hot path: 1. HwcDisplay::WaitForPresenttime(), where it looks at the expected present time of the frame and sleeps until it is close to it (0.75 vsync period away from the target vsync). 2. DrmAtomicStateManager::WaitLastFrame(), where it waits on the present fence of the last commit so that we don't call commit when another present is pending These are called in-order, which in certain multi-display configuration with heterogenous refresh rates can lead to the slower display locking up due to sleep in WaitForPresenttime(). This CL makes DrmAtomicStateManager::WaitLastFrame() public, and moves its invocation to right before the call to HwcDisplay::WaitForPresenttime(). This should minimize the impact of WaitForPresenttime(), and allow drm_hwcomposer to hit more present targets that it can hit. Test: atest GraphicsComposerAidlCommandTest Test: Manual testing w/ perfetto Change-Id: Ic9c07ff0b6d00dfafce5dd109d8195886dd3094e Signed-off-by: Su Hong Koo <sukoo@google.com> |
||
|---|---|---|
| .ci | ||
| backend | ||
| bufferinfo | ||
| compositor | ||
| drm | ||
| hwc | ||
| hwc2_device | ||
| hwc3 | ||
| stats | ||
| tests | ||
| utils | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| Android.bp | ||
| Makefile | ||
| meson.build | ||
| meson.options | ||
| MODULE_LICENSE_APACHE2 | ||
| NOTICE | ||
| README.md | ||
drm_hwcomposer
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
-
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
-
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
-
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file -
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!