1
0
Fork 0
android_external_drm_hwcomp.../utils/properties.cpp
Gil Dekel 3b2050b7f2 drm_hwcomposer: Re-enable MRR on AL devices
Configuration groups for the Multiple Refresh Rate (MRR) feature support
is currently disabled in DRM HWComposer. This is because it is
insufficient to group modes solely based on their active region size.

The primary reasons for this insufficiency are:
1. drm-hwc clients may assume they can seamlessly switch between
   configurations within the same group to support variable refresh
   rates.
2. Not all System-on-a-Chip (SoC) architectures support seamless mode
   transitions.
3. For SoCs that do support seamless switching, transitions often depend
   on other hardware-specific properties like matching blanking periods.
4. A fallback to a non-seamless (blocking) modeset is unacceptable for
   internal displays if a seamless transition fails, as this causes
   flickering. The current framework does not handle such failures
   gracefully.

To Resolve these challenges and re-enable seamless Multiple Refresh-Rate
transitions on internal panels, we add logic to validate all configs
against the preferred initial active config. This validation preforms a
seamless modeset test on each available config against the config that
was set during the display initialization. Configs that fail the
screening are assigned new group IDs.

Caveats:
1. Currently, this is only implemented for internal panels. External
   display seamless transition between variable refresh rates is not
   support. However this work can be extended to support seamless
   transitions on external displays as well.
2. Grouping is only preformed for the preffered/active config at the
   time of display init, and is valid only for the duration of the
   current full modeset commit. No other groups are not created (since
   they cannot be validated), and any new full commits will not honor
   the guarantee provided by the check. This work can be extended to
   refresh and validate all configs within the same group ID of any
   incoming full modeset commit.

Change-Id: Ie2661e74bd3ff704b40c8c7ef50c56e604e5e8df
Signed-off-by: Gil Dekel <gildekel@google.com>
2025-07-29 16:14:12 -04:00

147 lines
4.2 KiB
C++

/*
* Copyright (C) 2023 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "properties.h"
#include <string>
#include <android-base/properties.h>
#include "utils/log.h"
#ifdef ANDROID
#include <cutils/properties.h>
#else
#include <cstdio>
#include <cstdlib>
#include <cstring>
namespace {
// NOLINTNEXTLINE(readability-identifier-naming)
constexpr int PROPERTY_VALUE_MAX = 92;
// NOLINTNEXTLINE(readability-identifier-naming)
auto inline property_get(const char *name, char *value,
const char *default_value) -> int {
// NOLINTNEXTLINE (concurrency-mt-unsafe)
char *prop = std::getenv(name);
snprintf(value, PROPERTY_VALUE_MAX, "%s",
(prop == nullptr) ? default_value : prop);
return static_cast<int>(strlen(value));
}
/**
* Bluntly copied from system/core/libcutils/properties.cpp,
* which is part of the Android Project and licensed under Apache 2.
* Source:
* https://cs.android.com/android/platform/superproject/main/+/main:system/core/libcutils/properties.cpp;l=27
*/
auto inline property_get_bool(const char *key, int8_t default_value) -> int8_t {
if (!key)
return default_value;
int8_t result = default_value;
char buf[PROPERTY_VALUE_MAX] = {};
int len = property_get(key, buf, "");
if (len == 1) {
char ch = buf[0];
if (ch == '0' || ch == 'n') {
result = false;
} else if (ch == '1' || ch == 'y') {
result = true;
}
} else if (len > 1) {
if (!strcmp(buf, "no") || !strcmp(buf, "false") || !strcmp(buf, "off")) {
result = false;
} else if (!strcmp(buf, "yes") || !strcmp(buf, "true") ||
!strcmp(buf, "on")) {
result = true;
}
}
return result;
}
} // namespace
#endif
namespace android {
/**
* @brief Determine if the "Present Not Reliable" property is enabled.
*
* @return boolean
*/
auto Properties::IsPresentFenceNotReliable() -> bool {
return (property_get_bool("ro.vendor.hwc.drm.present_fence_not_reliable",
0) != 0);
}
auto Properties::InternalDisplayNames() -> std::string {
char buf[PROPERTY_VALUE_MAX] = {};
property_get("vendor.hwc.drm.internal_display_names", buf, "");
return {buf};
}
auto Properties::UseOverlayPlanes() -> bool {
return (property_get_bool("ro.vendor.hwc.use_overlay_planes", 1) != 0);
}
auto Properties::ScaleWithGpu() -> bool {
return (property_get_bool("vendor.hwc.drm.scale_with_gpu", 0) != 0);
}
auto Properties::EnableVirtualDisplay() -> bool {
return (property_get_bool("vendor.hwc.drm.enable_virtual_display", 0) != 0);
}
auto Properties::GetCtmHandling() -> CtmHandling {
char proptext[PROPERTY_VALUE_MAX];
constexpr char kDrmOrGpu[] = "DRM_OR_GPU";
constexpr char kDrmOrIgnore[] = "DRM_OR_IGNORE";
property_get("vendor.hwc.drm.ctm", proptext, "");
if (strncmp(proptext, kDrmOrGpu, sizeof(kDrmOrGpu)) == 0) {
return CtmHandling::kDrmOrGpu;
}
if (strncmp(proptext, kDrmOrIgnore, sizeof(kDrmOrIgnore)) == 0) {
return CtmHandling::kDrmOrIgnore;
}
ALOGE_IF(proptext[0] != '\0', "Invalid value for vendor.hwc.drm.ctm: %s",
proptext);
// Default value.
return CtmHandling::kDrmOrGpu;
}
auto Properties::GetBackendOverride() -> std::string {
char backend_override[PROPERTY_VALUE_MAX];
property_get("vendor.hwc.backend_override", backend_override, "");
return {backend_override};
}
auto Properties::GetDevicePath() -> std::string {
char path_pattern[PROPERTY_VALUE_MAX];
// Could be a valid path or it can have at the end of it the wildcard %
// which means that it will try open all devices until an error is met.
property_get("vendor.hwc.drm.device", path_pattern, "");
return {path_pattern};
}
} // namespace android