Under the previous behavior, NewFrame both updated the internal state tracking to indicate that the scene is not idle, as well as returning a bool to indicate whether the scene should be flattened or not. ShouldFlatten was not being used, and would return `true` during the interval between the refresh callback being triggered and the next NewFrame, which would be in response to the refresh callback. Subsequent calls to ShouldFlatten would return `false` even though the scene remains idle. This commit updates NewFrame to only update the internal state. Callers should call ShouldFlatten to check whether the controller has detected that the scene should be flattened. After the callback is triggered, ShouldFlatten returns true. It will continue to return true after the first NewFrame, which would be in response to the refresh callback. Subsequent NewFrame calls will reset the idle detection. Change-Id: I8b11a55bb6b101bb2ce473a844f5b9795a027956 |
||
|---|---|---|
| .ci | ||
| backend | ||
| bufferinfo | ||
| compositor | ||
| drm | ||
| hwc | ||
| hwc2_device | ||
| hwc3 | ||
| stats | ||
| tests | ||
| utils | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| Android.bp | ||
| Makefile | ||
| meson.build | ||
| meson.options | ||
| MODULE_LICENSE_APACHE2 | ||
| NOTICE | ||
| README.md | ||
drm_hwcomposer
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
-
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
-
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
-
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file -
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!