lineage-rockchip/android_external_drm_hwcomposer
1
0
Fork 0
Code Activity Actions

drm_hwcomposer: Tracking of the DRM FB objects using RAII

Browse source 
DRM framebuffer objects must be kept registered in DRM/KMS
while used for scanning-out (After atomic commit applied
for processing by display controller and until next atomic
commit is applied for processing).

Existing logic for tracking current state is overcomplicated and
needs to be redesigned. Also further developing of drm_hwc will
require migration to asynchronous atomic commit, so additional
asynchronous FB cleanup logic must be created.
Buffer caching logic will also benefit from this.

With the RAII all further changes will be less painful and more robust.

By this commit I also renamed DrmGenericImporter to DrmFbImporter:
'Fb' word is present in most of existing composers (android and linux)
so it will be easier to compare different implementations.

Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
This commit is contained in:
Roman Stratiienko 2021-02-09 17:49:55 +02:00
parent 92c6a40d52
commit 8666dc9c58
16 changed files with 321 additions and 292 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compositor/DrmDisplayCompositor.cpp
View file

@ -290,7 +290,7 @@ int DrmDisplayCompositor::CommitFrame(DrmDisplayComposition *display_comp,
ALOGE("Expected a valid framebuffer for pset");
break;
}
fb_id = layer.buffer->fb_id;
fb_id = layer.buffer.FbIdHandle->GetFbId();
fence_fd = layer.acquire_fence.get();
display_frame = layer.display_frame;
source_crop = layer.source_crop;